[Maxima] [Maxima-commits] CVS: maxima/src sin.lisp,1.22,1.23
robert.dodier at gmail.com
Tue Feb 20 13:31:52 CST 2007
On 2/20/07, Raymond Toy <raymond.toy at ericsson.com> wrote:
> Could we please keep the removal of junk separate from indentation
> changes? It makes it hard to keep track of what's happening.
Agreed, let's separate the whitespace stuff from other changes.
> Also, I see that you've replaced (memq x foo) everywhere with (member
> x foo :test #'eq). Is that really necessary?
I'm not opposed to replacing MEMQ (along with several other CL
implementations of what appear to be Maclispisms) with the CL
equivalent. It is better to have the code be comprehensible to an
ordinary CL programmer (ignoring the question of general
incomprehensibility). There are many obstacles to understanding
the Maxima code; arbitrarily replacing CL functions need not be
one of them.
More information about the Maxima